Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5972: Game Options #6121

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 19, 2024

Fixes #5972
Options in the search tab will now also update properly then the game options are changed elsewhere

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (c6d30f7) to head (13d461e).
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6121      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13972    13971       -1     
============================================
  Files          2601     2601              
  Lines        267447   267455       +8     
  Branches      47758    47758              
============================================
- Hits          77767    77765       -2     
- Misses       185782   185795      +13     
+ Partials       3898     3895       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -29,7 +29,8 @@
import megamek.common.options.*;

/** @author Cord Awtry */
public class DialogOptionComponent extends FixedYPanel implements ItemListener, ActionListener, Comparable<DialogOptionComponent> {
public class DialogOptionComponent extends FixedYPanel implements ItemListener,

Check warning

Code scanning / CodeQL

Inconsistent compareTo Warning

This class declares
compareTo
but inherits equals; the two could be inconsistent.
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, not sure about the security warning.

@HammerGS HammerGS merged commit 5d4e9d6 into MegaMek:master Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.x-0.50.0+] Game Options ignores textbox value changes when in Search
2 participants